Add config toggles for Dynmap island markers and area boxes#2991
Merged
Conversation
On worlds with many tightly-packed islands, the house icon marker and protected-area border box BentoBox draws on Dynmap for every island can flood the map. Add two config options under a new `dynmap` section: - dynmap.island-markers (default true): show the center house icon - dynmap.island-areas (default true): draw the protected area border box DynmapHook now checks these settings before creating each marker type. Defaults preserve existing behaviour. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
BentoBox's Dynmap integration draws, for every island:
On worlds with many tightly-packed islands, these can flood the Dynmap view. Until now the only ways to hide them were per-viewer (untick the layer) or via Dynmap commands (
/dmarker updateset … hide:true,/dmarker deleteset …) — and the latter isn't permanent because BentoBox re-creates and re-populates the set on restart and on island create/reset/rename/delete events.Change
Adds a new
dynmapconfig section with two toggles:DynmapHooknow checks each setting before creating the corresponding marker. Both default totrue, so existing behaviour is unchanged. Changes take effect after a server restart or/bbox reload.Tests
Added two tests to
DynmapHookTest:testIslandMarkersDisabledNoPointMarker— no point marker created, area box still drawntestIslandAreasDisabledNoAreaMarker— house icon still placed, no area box🤖 Generated with Claude Code